fix: space pkm response to max once per minute #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Jan 9, 2025
flow/connectors/postgres/cdc.go
Outdated
| @@ -386,7 +386,8 @@ func PullCdcRecords[Items model.Items]( | |||
|
|
|||
| for { | |||
| if pkmRequiresResponse { | |||
| if cdcRecordsStorage.IsEmpty() && int64(clientXLogPos) > req.ConsumedOffset.Load() { | |||
| if cdcRecordsStorage.IsEmpty() && int64(clientXLogPos) > req.ConsumedOffset.Load() && | |||
| time.Since(standByLastLogged) >= 1*time.Minute { | |||
There was a problem hiding this comment.
ideally we'd throttle this based on this update, not alongside existing logging code. Or move logging code in here & only log once a minute
As is we may be logging every 10s & never update offset
iamKunalGupta
force-pushed
the
fix/send-pkm-response-1-per-minute
branch
from
6415919 to
7755201
Compare
serprex
reviewed
Jan 10, 2025
flow/connectors/postgres/cdc.go
Outdated
| @@ -383,7 +384,12 @@ func PullCdcRecords[Items model.Items]( | |||
|
|
|||
| pkmRequiresResponse := false | |||
| waitingForCommit := false | |||
|
|
|||
| pkmEmptyBatchThrottleEnabled, err := peerdbenv.PeerDBPKMEmptyBatchThrottleEnabled(ctx, nil) | |||
There was a problem hiding this comment.
Suggested change
| pkmEmptyBatchThrottleEnabled, err := peerdbenv.PeerDBPKMEmptyBatchThrottleEnabled(ctx, nil) | |
| pkmEmptyBatchThrottleEnabled, err := peerdbenv.PeerDBPKMEmptyBatchThrottleEnabled(ctx, req.Env) |
serprex
reviewed
Jan 10, 2025
iamKunalGupta
changed the title
serprex
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.